[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: altas 3.1b



Camm,

>Need this line at line 200 in gemvtune:
>
>	 *lda= *lda < *N ? *N : *lda;

My line 200 is:
         *N = atoi(args[++i]);
and adding the line you suggest, if I understand correctly, would make
lda incorrect for the notrans case . . .

The expectation is that the user, if he does not accept the defaults
for M, N, lda, will set them correctly (the defaults are correct).
If you want to guard against error here, you could think about adding
something like:
   if (*cta == 'N' && *lda < Mmax(1,*M))
   {
      fprintf(stderr, "Illegal lda=%d, M=%d\n", *lda, *M);
      exit(0);
   }
   else if (*lda < Mmax(1,*N))
   {
      fprintf(stderr, "Illegal lda=%d, M=%d\n", *lda, *M);
      exit(0);
   }
to line 213.

Cheers,
Clint